Exposed name and native name to enable Cucumber-JVM to print the lang…#366
Closed
Exposed name and native name to enable Cucumber-JVM to print the lang…#366
Conversation
…uage name in English, the native name and the language code.
6 tasks
Contributor
|
This PR has gone stale in the light of #425. Gherkin 6 will have a Thanks for your contribution though! |
6 tasks
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cucumber-JVM can't print the name and native name for a supported language. I exposed two methods in Gherkin so the name and native name can be read from Cucumber-JVM.
Details
This is the same as the pull request #313 but with only one commit. #313 was a mistake in the sense that it started out with a Gherkin change that made the Java implementation diverge from the other implementations. exposing two methods like this is less intrusive.
Motivation and Context
This will make it easier to understand what language a language code is supporting.
How Has This Been Tested?
I added unit tests that veriffies that it is possible to get the name 'Swedish' and the native name 'Svenska'
Screenshots (if appropriate):
Types of changes
Checklist: