Skip to content

Exposed name and native name to enable Cucumber-JVM to print the lang…#366

Closed
tsundberg wants to merge 1 commit intomasterfrom
include-name-and-local-name
Closed

Exposed name and native name to enable Cucumber-JVM to print the lang…#366
tsundberg wants to merge 1 commit intomasterfrom
include-name-and-local-name

Conversation

@tsundberg
Copy link
Copy Markdown
Member

Summary

Cucumber-JVM can't print the name and native name for a supported language. I exposed two methods in Gherkin so the name and native name can be read from Cucumber-JVM.

Details

This is the same as the pull request #313 but with only one commit. #313 was a mistake in the sense that it started out with a Gherkin change that made the Java implementation diverge from the other implementations. exposing two methods like this is less intrusive.

Motivation and Context

This will make it easier to understand what language a language code is supporting.

How Has This Been Tested?

I added unit tests that veriffies that it is possible to get the name 'Swedish' and the native name 'Svenska'

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

…uage name in English, the native name and the language code.
@aslakhellesoy
Copy link
Copy Markdown
Contributor

This PR has gone stale in the light of #425. Gherkin 6 will have a --dialects option for printing the JSON file, which can be piped to various tools for generating documentation or code.

Thanks for your contribution though!

@luke-hill luke-hill deleted the include-name-and-local-name branch March 20, 2019 09:45
@lock
Copy link
Copy Markdown

lock bot commented Mar 21, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants