Skip to content

refactoring: use stl regex instead of boost::regex#266

Merged
ursfassler merged 1 commit intocucumber:mainfrom
ursfassler:std-c++-regex
Dec 17, 2023
Merged

refactoring: use stl regex instead of boost::regex#266
ursfassler merged 1 commit intocucumber:mainfrom
ursfassler:std-c++-regex

Conversation

@ursfassler
Copy link
Copy Markdown
Contributor

Summary

Use standard library regex instead of boost one.

Details

Refactoring to remove no longer needed dependencies.
This removes the support for repeated captures (i.e. boost::regex_constants::match_extra), which may break some use cases. It is expected that such use cases are rare.

Motivation and Context

Less dependencies for functionality that is provided by the standard library.

How Has This Been Tested?

This is a refactoring, it should not change the behavior (expect for repeated captures). All automated tests still work.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • It is my own work, its copyright is implicitly assigned to the project and no substantial part of it has been copied from other sources (including Stack Overflow). In rare occasions this is acceptable, like in CMake modules where the original copyright information should be kept.
  • I'm using the same code standards as the existing code (indentation, spacing, variable naming, ...).
  • I've added tests for my code.
  • I have verified whether my change requires changes to the documentation
  • My change either requires no documentation change or I've updated the documentation accordingly.
  • My branch has been rebased to main, keeping only relevant commits.

@ursfassler ursfassler marked this pull request as draft December 17, 2023 10:07
@ursfassler ursfassler marked this pull request as ready for review December 17, 2023 10:51
This removes the support for repeated captures (i.e.
boost::regex_constants::match_extra), which may break some use cases. It
is expected that such use cases are rare.
@ursfassler ursfassler merged commit d0edbee into cucumber:main Dec 17, 2023
@ursfassler ursfassler deleted the std-c++-regex branch December 17, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant