Skip to content

Modernize overloading#267

Merged
ursfassler merged 2 commits intocucumber:mainfrom
ursfassler:modernize-overloading
Dec 18, 2023
Merged

Modernize overloading#267
ursfassler merged 2 commits intocucumber:mainfrom
ursfassler:modernize-overloading

Conversation

@ursfassler
Copy link
Copy Markdown
Contributor

Summary

Use more modern language features when overloading.

Details

  • Enforce the use of override keyword when overriding methods
  • Use "default" for empty virtual destructors

Motivation and Context

Modernization of the code base.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • It is my own work, its copyright is implicitly assigned to the project and no substantial part of it has been copied from other sources (including Stack Overflow). In rare occasions this is acceptable, like in CMake modules where the original copyright information should be kept.
  • I'm using the same code standards as the existing code (indentation, spacing, variable naming, ...).
  • I've added tests for my code.
  • I have verified whether my change requires changes to the documentation
  • My change either requires no documentation change or I've updated the documentation accordingly.
  • My branch has been rebased to main, keeping only relevant commits.

@ursfassler ursfassler marked this pull request as draft December 17, 2023 21:15
@ursfassler ursfassler marked this pull request as ready for review December 18, 2023 20:44
@ursfassler ursfassler merged commit 735c02f into cucumber:main Dec 18, 2023
@ursfassler ursfassler deleted the modernize-overloading branch December 18, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant