use nlohmann/json library#273
Merged
ursfassler merged 3 commits intocucumber:mainfrom Dec 28, 2023
Merged
Conversation
Removes compiler warnings and dependency to boost.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use nlohmann/json library instead of json spirit.
Details
This PR replaces the json parser/serializer used for the wire protocol.
Motivation and Context
The existing json library was responsible for compiler warnings. A newer version of the library was not found.
Also removes dependency to boost as the new json library has no dependencies.
How Has This Been Tested?
It is a refactoring for part of the code that has unit tests and is used to execute the examples.
Types of changes
Checklist: