Reuse internal Locale's cache instead of custom cache #3117
+1
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
As a side-effect of your response within #376 I took a deeper look to all positions where the
Localeinformation is stored. Doing so, I found a customLocalecache even though theLocaleclass already provides an internal caching mechanism (Locale#LOCALECACHE). Admittedly, this cache will not be used when creatingLocaleinstances by any of theLocaleconstructors. Instead, one must use theLocale.Builder.This PR removes the custom
Localecache and reuses the Java built-in cache mechanism.⚡️ What's your motivation?
I like the idea of having "a single source of truth", and this PR removes one of the code positions where the current
Localeinformation is stored a second time.🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
No.
📋 Checklist: