Skip to content

Reuse internal Locale's cache instead of custom cache #3117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2025
Merged

Reuse internal Locale's cache instead of custom cache #3117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions cucumber-core/src/main/java/io/cucumber/core/runner/Runner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,8 @@
import java.net.URI;
import java.util.ArrayList;
import java.util.Collection;
import java.util.HashMap;
import java.util.List;
import java.util.Locale;
import java.util.Map;
import java.util.Objects;

import static io.cucumber.core.exception.ExceptionUtils.throwAsUncheckedException;
Expand All @@ -42,7 +40,6 @@ public final class Runner {
private final Collection<? extends Backend> backends;
private final Options runnerOptions;
private final ObjectFactory objectFactory;
private final Map<String, Locale> localeCache = new HashMap<>();
private List<SnippetGenerator> snippetGenerators;

public Runner(
Expand Down Expand Up @@ -84,7 +81,7 @@ public void runPickle(Pickle pickle) {

private Locale localeForPickle(Pickle pickle) {
String language = pickle.getLanguage();
return localeCache.computeIfAbsent(language, (lang) -> new Locale(language));
return new Locale.Builder().setLanguage(language).build();
}

public void runBeforeAllHooks() {
Expand Down