Raise a `TagExcess` before executing test suite

[tom025]

As pointed out by @pdswan.

The current version of cucumber raises a TagExcess before executing the test suite. Cucumber core will only raise a TagExcess after it has executed the test suite.

This issue needs to be addressed for cucumber 2.0 to be compatible with the current version of cucumber.

[mattwynne]

As discussed last night Tom, I think we can achieve this just by getting the Runtime to queue up all the TestCases before it starts to execute them. Want to try it in a branch?

[tom025]

Sure. I will give this a go in a branch and push it up for discussion.

Regards
Tom

On Thu, Feb 13, 2014 at 5:23 PM, Matt Wynne notifications@github.comwrote:

As discussed last night Tom, I think we can achieve this just by getting
the Runtime to queue up all the TestCases before it starts to execute them.
Want to try it in a branch?

Reply to this email directly or view it on GitHubhttps://github.com//issues/54#issuecomment-35002411
.

[mattwynne]

Thinking about it, the right way to approach this, I think, is to build a BatchingFilter which you put into the filter chain after the TagExcess filter (or maybe the TagExcess filter could somehow automatically add it when it's added). We'd need a similar BatchingFilter for a RandomizerFilter which will be an awesome new feature for 2.0!

The BatchingFilter's job will just be to batch up all the test cases, and only release them when it hears the done message. I think that could work.

[tom025]

cucumber/common#633 has fixed this issue.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.