Skip to content

Conversation

@aurelien-reeves
Copy link
Contributor

@aurelien-reeves aurelien-reeves commented Aug 4, 2021

Description

Moving the CI from Circle CI to Gihub actions.

Regular (ubuntu) builds: ✔
Windows builds: ✔
JRuby build: ✔
🆕 MacOS builds 🆕: ✔

The previous GitHub workflow was designed to push to cucumber reports, but it did not worked anymore since personal tokens have been deprecated on reports. It has been removed, we may consider recreating a dedicated workflow for that purpose if we want to, with a new collection token.

If we want to activate back the CCK tests, we could created a dedicated workflow too

I noticed that we are using a pretty old version of Rubocop, and updating it reveals a lot of offenses. I suggest to try upgrading it as part of another PR to avoid blocking this one.

Type of change

Please delete options that are not relevant.

  • Refactoring (improvements to code design or tooling that don't change behaviour)

Checklist:

Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.

  • New and existing tests are passing locally and on CI
  • bundle exec rubocop reports no offenses

@aurelien-reeves aurelien-reeves marked this pull request as draft August 4, 2021 13:07
@aurelien-reeves
Copy link
Contributor Author

aurelien-reeves commented Aug 4, 2021

It seems that the build does not work on windows with ruby 2.5 for unknown reason.
Still, we have ruby 2.6, 2.7 and 3.0 which are running on Windows successfully. With circle-ci, we had only one build, and I can't even figure out which version of ruby it is.

@aurelien-reeves aurelien-reeves marked this pull request as ready for review August 4, 2021 13:37
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am for going forward with this as it is now.

Copy link
Contributor

@luke-hill luke-hill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably optimise this method whilst we're here.

@aurelien-reeves aurelien-reeves merged commit 3fc5584 into main Aug 5, 2021
@aurelien-reeves aurelien-reeves deleted the move-ci-to-gh-workflows branch August 5, 2021 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants