-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Move CI to GitHub actions #1565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It seems that the build does not work on windows with ruby 2.5 for unknown reason. |
olleolleolle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am for going forward with this as it is now.
luke-hill
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably optimise this method whilst we're here.
Description
Moving the CI from Circle CI to Gihub actions.
Regular (ubuntu) builds: ✔
Windows builds: ✔
JRuby build: ✔
🆕 MacOS builds 🆕: ✔
The previous GitHub workflow was designed to push to cucumber reports, but it did not worked anymore since personal tokens have been deprecated on reports. It has been removed, we may consider recreating a dedicated workflow for that purpose if we want to, with a new collection token.
If we want to activate back the CCK tests, we could created a dedicated workflow too
I noticed that we are using a pretty old version of Rubocop, and updating it reveals a lot of offenses. I suggest to try upgrading it as part of another PR to avoid blocking this one.
Type of change
Please delete options that are not relevant.
Checklist:
Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.
bundle exec rubocopreports no offenses