failure scenario with --strict. previously marked with @wip #657
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This @wip is a scenario in
strict_mode.feature, which fails because the code doesn't produce the following expected output:The relevant implementation in the old core is in
step_invocation.rb. In the new implementation, theUndefinedclass in cucumber-ruby-core'sresult.rbdoesn't inherit fromStandardError, soLegacyResultBuilder's@exceptionneeded to be set explicitly. In addition, the configuration--strictalso need to be made available to theScenarioPrinter. I chose to expose that viaruntime(not sure if this is appropriate, or maybe there are better ways to do this?). Feedback appreciated.