Skip to content

Conversation

@serixscorpio
Copy link
Contributor

This @wip is a scenario in strict_mode.feature, which fails because the code doesn't produce the following expected output:

Undefined step: "this step passes" (Cucumber::Undefined)
features/missing.feature:3:in `Given this step passes'

The relevant implementation in the old core is in step_invocation.rb. In the new implementation, the Undefined class in cucumber-ruby-core's result.rb doesn't inherit from StandardError, so LegacyResultBuilder's @exception needed to be set explicitly. In addition, the configuration --strict also need to be made available to the ScenarioPrinter. I chose to expose that via runtime (not sure if this is appropriate, or maybe there are better ways to do this?). Feedback appreciated.

@mattwynne
Copy link
Member

Thanks for this contribution, I'm really sorry nobody commented on it before!

I'm very impressed you managed to get your head around this code - it's pretty complicated. Please do continue to track the tickets in the 2.0 milestone and fix any that you fancy.

@mattwynne mattwynne closed this Dec 22, 2014
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants