Skip to content

Get location directly from pickle #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 19, 2025
Merged

Get location directly from pickle #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
191f8a8
bump messages
davidjgoss Nov 19, 2025
aa02ae9
bump gherkin
davidjgoss Nov 19, 2025
287fb2f
get location directly from pickle
davidjgoss Nov 19, 2025
c774a63
set messages version requirement
davidjgoss Nov 19, 2025
ca1d7f9
update CHANGELOG.md
davidjgoss Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
### Changed
- Require messages v31 or greater ([#30](https://github.com/cucumber/javascript-core/pull/30))

## [0.6.0] - 2025-11-17
### Added
Expand Down
20 changes: 10 additions & 10 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,14 @@
"homepage": "https://github.com/cucumber/javascript-core#readme",
"peerDependencies": {
"@cucumber/cucumber-expressions": "*",
"@cucumber/messages": "*",
"@cucumber/messages": ">=31.0.0",
"@cucumber/query": "*",
"@cucumber/tag-expressions": "*"
},
"devDependencies": {
"@cucumber/cucumber-expressions": "^18.0.1",
"@cucumber/gherkin": "^36.0.0",
"@cucumber/messages": "^30.0.0",
"@cucumber/gherkin": "^37.0.0",
"@cucumber/messages": "^31.0.0",
"@cucumber/query": "^14.0.0",
"@cucumber/tag-expressions": "^8.0.0",
"@eslint/js": "^9.31.0",
Expand Down
2 changes: 1 addition & 1 deletion src/makeTestPlan.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export function makeTestPlan(
name: gherkinDocument.feature?.name || gherkinDocument.uri,
testCases: pickles.map((pickle) => {
const lineage = query.findLineageBy(pickle) as Lineage
const location = query.findLocationOf(pickle) as MessagesLocation
const location = pickle.location as MessagesLocation
return {
id: newId(),
pickleId: pickle.id,
Expand Down