Skip to content

bin: fix startServer import and wasm paths#30

Merged
aurelien-reeves merged 2 commits into
cucumber:mainfrom
williamboman:fix-startServer-import
Feb 11, 2022
Merged

bin: fix startServer import and wasm paths#30
aurelien-reeves merged 2 commits into
cucumber:mainfrom
williamboman:fix-startServer-import

Conversation

@williamboman

@williamboman williamboman commented Feb 6, 2022

Copy link
Copy Markdown
Contributor

Description

It seems like the latest release broke the executable, where it's throwing the following exception:

/Users/williamboman/.local/share/nvim/lsp_servers/cucumber_language_server/node_modules/@cucumber/language-server/bin/cucumber-language-server.cjs:10
startServer(wasmUrls)
^
TypeError: startServer is not a function
    at Object.<anonymous> (/Users/williamboman/.local/share/nvim/lsp_servers/cucumber_language_server/node_modules/@cucumber/language-server/bin/cucumber-language-server.cjs:10:1)
    at Module._compile (node:internal/modules/cjs/loader:1101:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:17:47

Motivation & context

It fixes the import of startServer, which is not a default export.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • My change needed additional tests
    • I have added tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@williamboman williamboman changed the title bin: fix startServer import bin: fix startServer import and wasm paths Feb 6, 2022
@aslakhellesoy

aslakhellesoy commented Feb 6, 2022

Copy link
Copy Markdown
Contributor

Thanks @williamboman!

Out of curiosity - what LSP client/editor are you using this with? I'm guessing neovim :-) How is it working for you?

@williamboman

williamboman commented Feb 7, 2022

Copy link
Copy Markdown
Contributor Author

Hey @aslakhellesoy. I honestly don't really use this server myself. I've only tried it out using the neovim native LSP client. I found about this issue via tests in https://github.com/williamboman/nvim-lspconfig-test

@aslakhellesoy

Copy link
Copy Markdown
Contributor

Oh very cool! I found it over in https://github.com/williamboman/nvim-lspconfig-test/tree/develop/tests/cucumber_language_server

Great to have someone else testing our code :-)

@aurelien-reeves aurelien-reeves merged commit f08cacb into cucumber:main Feb 11, 2022
@aslakhellesoy

Copy link
Copy Markdown
Contributor

Hi @williamboman,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@williamboman williamboman deleted the fix-startServer-import branch February 11, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants