This repository was archived by the owner on Sep 26, 2023. It is now read-only.
cmd/unity: do not recurse into cue.mod when searching for modules #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finding a cue.mod directory indicates we have found a module. Currently,
we continue to recurse into a cue.mod directory to find other modules.
However, this is not correct from the perspective of unity: any modules
we find within cue.mod/{gen,pkg,usr} will only ever be modules vendored
as dependencies of the module we have just found, which from unity's
perspective is not what we are after.
Therefore skip cue.mod directories themselves.
Fixes #59
Contributor
Author
|
cc @eonpatapon |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finding a cue.mod directory indicates we have found a module. Currently,
we continue to recurse into a cue.mod directory to find other modules.
However, this is not correct from the perspective of unity: any modules
we find within cue.mod/{gen,pkg,usr} will only ever be modules vendored
as dependencies of the module we have just found, which from unity's
perspective is not what we are after.
Therefore skip cue.mod directories themselves.
Fixes #59