Skip to content

Removing err field#153

Merged
matin merged 4 commits intomainfrom
removing_err_arpc
Apr 25, 2021
Merged

Removing err field#153
matin merged 4 commits intomainfrom
removing_err_arpc

Conversation

@chiqeen03
Copy link
Copy Markdown
Contributor

El campo err fue removido en Knox en el PR
https://github.com/cuenca-mx/knox/pull/125/commits/dff386f4b342b2c3852f04cfba6390012e5ffc56#diff-f452974a4668fe9c496326a58b74a4b57be69f477930b125171cfa07b5597f1fL22

Se remueve el campo en este PR para tener consistencia con las clases.

closes #152

@chiqeen03 chiqeen03 added the bug Something isn't working label Apr 23, 2021
@chiqeen03 chiqeen03 requested a review from pachCode April 23, 2021 22:27
@chiqeen03 chiqeen03 self-assigned this Apr 23, 2021
@chiqeen03 chiqeen03 requested a review from matin as a code owner April 23, 2021 22:27
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 23, 2021

Codecov Report

Merging #153 (ca6350b) into main (72c485a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #153   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines          652       651    -1     
=========================================
- Hits           652       651    -1     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cuenca/resources/arpc.py 100.00% <ø> (ø)
cuenca/version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72c485a...ca6350b. Read the comment docs.

@chiqeen03 chiqeen03 removed the request for review from pachCode April 23, 2021 22:30
@matin matin merged commit 4e0bbbb into main Apr 25, 2021
@matin matin deleted the removing_err_arpc branch April 25, 2021 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remover campo err de arpc

2 participants