✨ New Resources - File and FileBatch by LuisBrime · Pull Request #226 · cuenca-mx/cuenca-python

LuisBrime · 2022-02-09T20:37:02Z

First approach of File resource.

The goal is to use the resource like this:

from io import BytesIO

import cuenca
from cuenca_validations.types import KYCFileType

# Upload a file
with open('my_file_to_upload.png', 'rb') as file:
  encrypted_file = cuenca.File.upload(
      file=BytesIO(file.read()),   # Not sure this is the best way to pass the file
      user_id='US01',              # user_id can be passed to upload a file from another user (omni does this)
      file_type=KYCFileType.ine,   # Pass type of document
      extension='png',             # If not passed, it will be calculated with the bytes but it might not be accurate
  )

encrypted_file.file # Returns bytes of the decrypted file

# Query also is delimited by `user_id`
cuenca.File.all(type=KYCFileType.proof_of_address)
cuenca.File.first(type=KYCFileType.ine)

First approach of FileBatch resource.

The goal is to send patzcuaro multiple links with their KYCFileType. patzcuaro will download, encrypt and save the files, and return the s3 URLs where the files are being saved.

import cuenca
from cuenca_validatons.types import KYCFileType

files = []
files.append(dict(url='XXXX', type=KYCFileType.passport))
files.append(dict(url='XXXX', type=KYCFileType.proof_of_liveness))
files.append(dict(url='XXXX', type=KYCFileType.proof_of_address))

batch = cuenca.FileBatch.create(files=files, user_id='USXXXXXX')

for file in batch.uploaded_files:
  file.url      # https://stage.cuenca.com/files/XXXX
  file.type     # KYCFileType.X

codecov · 2022-02-09T20:37:44Z

Codecov Report

Merging #226 (9c2a052) into main (f22c4ba) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #226   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           35        37    +2     
  Lines          873       927   +54     
=========================================
+ Hits           873       927   +54

Flag	Coverage Δ
unittests	`100.00% <100.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
cuenca/__init__.py	`100.00% <ø> (ø)`
cuenca/http/client.py	`100.00% <100.00%> (ø)`
cuenca/resources/__init__.py	`100.00% <100.00%> (ø)`
cuenca/resources/base.py	`100.00% <100.00%> (ø)`
cuenca/resources/file_batches.py	`100.00% <100.00%> (ø)`
cuenca/resources/files.py	`100.00% <100.00%> (ø)`
cuenca/version.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f22c4ba...9c2a052. Read the comment docs.

alexviquez

ahí va, hay que ajustarlo

alexviquez · 2022-02-09T20:53:31Z

cuenca/resources/files.py

+
+
+@dataclass
+class File(Creatable, Downloadable, Queryable):


alexviquez · 2022-02-09T21:09:40Z

cuenca/resources/files.py

+    @classmethod
+    def create(
+        cls,
+        file: BytesIO,
+        *,
+        session: Session = global_session,
+    ) -> 'File':
+        """
+        Stores an encrypted version of the file,
+        only users with permissions can access it.
+
+        :param session:
+        :return: New encrypted file object
+        """
+        req = FileRequest(file=file.read())
+        response = session.post(


hay que usar uploadable para acá

alexviquez · 2022-02-09T21:10:10Z

cuenca/resources/files.py

+    @property
+    def pdf(self) -> bytes:
+        """
+        Override property value for `Donwlodable`
+        """
+        return self.file


pon mejor un raise de NotImplementedError

alexviquez

Unos comments respecto al user_id, no es necesario que lo pases en el body del request, vive en toda la sesión gracias a los blueprints, revisa como funcionan acá:
https://github.com/cuenca-mx/agave

alexviquez · 2022-02-10T18:16:16Z

cuenca/resources/base.py

+        resp = session.request(
+            'post',
+            cls._resource,
+            data=dict(user_id=user_id),


No necesitas majera el user_id en el cuerpo del post request, el user_id lo tienes en toda la sesión

cuenca/resources/files.py

alexviquez

Unos cambios, el meme del perrito esta genial jaja

alexviquez · 2022-03-04T21:59:09Z

tests/resources/test_file_batches.py

+            url='https://media.getmati.com/file?location=XXX1',
+            type=KYCFileType.ine,
+            is_back=True,
+        ),
+        dict(
+            url='https://media.getmati.com/file?location=XXX2',
+            type=KYCFileType.proof_of_liveness,
+        ),
+        dict(
+            url='https://media.getmati.com/file?location=XXX3',
+            type=KYCFileType.proof_of_address,


cambia el path, debe ser no genérico

cuenca/resources/base.py

cuenca/resources/users.py

requirements.txt

tests/resources/cassettes/test_file_batch_create.yaml

alexviquez

unos comments

alexviquez · 2022-03-07T19:08:42Z

requirements-dev.txt

@@ -0,0 +1 @@
+python-magic-bin==0.4.14


alexviquez · 2022-03-07T19:08:48Z

cuenca/version.py

@@ -1,3 +1,3 @@
-__version__ = '0.7.14'
+__version__ = '0.7.16.dev1'


ajustar versión

alexviquez · 2022-03-07T19:08:54Z

Makefile

+install-dev: install-test
+	pip install -qU -r requirements-dev.txt


esto se va también

alexviquez · 2022-03-07T19:09:29Z

setup.py

    python_requires='>=3.6',
    install_requires=[
        'requests>=2.24,<28',
-        'cuenca-validations>=0.9.18,<0.9.19',


cambiar esto

LuisBrime added the enhancement New feature or request label Feb 9, 2022

LuisBrime requested a review from alexviquez February 9, 2022 20:37

LuisBrime self-assigned this Feb 9, 2022

alexviquez suggested changes Feb 9, 2022

View reviewed changes

alexviquez suggested changes Feb 10, 2022

View reviewed changes

LuisBrime added 6 commits February 28, 2022 22:41

first approach of File resource

6430ee9

Updatable and comments

c234418

changed user_id approach

38f544b

changed how the user_id is uploaded

8d4ff60

different validation and sending form as str

b3dcd7a

encode uploaded file and use user_id

1db7581

LuisBrime force-pushed the patzcuaro branch from 092aac9 to 1db7581 Compare March 1, 2022 04:41

LuisBrime added 5 commits February 28, 2022 23:24

added tests

4a6bfc8

updated cuenca-validation file types

1358e59

added bin dependency

b367e79

updated dependencies ?

fedf424

added FileBatch resource

407ea31

LuisBrime changed the title ~~New Resource - File~~ ✨ New Resources - File and FileBatch Mar 2, 2022

LuisBrime added 7 commits March 2, 2022 19:53

send is_back on requests

d6e2dc5

remove line for identify

17792f9

type for batch metadata

d6d3a94

added clabe for users

8585146

lint

c126e66

fixed tests

8eee22d

dev dependency magic lib

edebbda

LuisBrime requested a review from alexviquez March 4, 2022 16:45

fixed cassette to current response

8aa3ebd

alexviquez suggested changes Mar 7, 2022

View reviewed changes

generic links, removed not mine and bump validations

d369571

alexviquez suggested changes Mar 7, 2022

View reviewed changes

remove unused stuff and bring back lines

9c2a052

alexviquez approved these changes Mar 7, 2022

View reviewed changes

alexviquez merged commit f122b4c into cuenca-mx:main Mar 7, 2022

LuisBrime deleted the patzcuaro branch March 8, 2022 06:40

		@@ -1,3 +1,3 @@
		__version__ = '0.7.14'
		__version__ = '0.7.16.dev1'

		install-dev: install-test
		pip install -qU -r requirements-dev.txt

		@@ -0,0 +1 @@
		python-magic-bin==0.4.14

Conversation

LuisBrime commented Feb 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Feb 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

alexviquez left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexviquez left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alexviquez left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alexviquez left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

LuisBrime commented Feb 9, 2022 •

edited

Loading

codecov bot commented Feb 9, 2022 •

edited

Loading