Add phone_verification_id and email_verification_id to User.update #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agarrido19
changed the title
Codecov Report
@@ Coverage Diff @@
## main #287 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 43 43
Lines 1005 1005
=========================================
Hits 1005 1005
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
andreshndz
suggested changes
Jun 28, 2022
Contributor
andreshndz
left a comment
andreshndz
left a comment
There was a problem hiding this comment.
Yo haría un test pequeño para probar que funciona bien si enviamos los ids de verificaciones
cuenca/version.py
Outdated
| @@ -1,3 +1,3 @@ | |||
| __version__ = '0.13.2' | |||
| __version__ = '0.13.4.dev1' | |||
requirements.txt
Outdated
| @@ -1,3 +1,3 @@ | |||
| requests==2.27.1 | |||
| cuenca-validations==0.10.15 | |||
| cuenca-validations==0.10.17.dev0 | |||
andreshndz
suggested changes
Jun 28, 2022
| uri: https://sandbox.cuenca.com/users/USV6ONckmjQNOM9p3_bRMyxg | ||
| response: | ||
| body: | ||
| string: '{"id":"USV6ONckmjQNOM9p3_bRMyxg","identity_uri":"/identities/IDvq7J_lS0Sr2E6C62oCfn3g","created_at":"2022-06-24T16:26:56.882000","updated_at":"2022-06-28T20:27:10.579110","platform_id":"PTZbBlk__kQt-wfwzP5nwA9A","level":0,"required_level":4,"phone_number":"+525529372492","email_address":"mail@cuenca.com","profession":null,"clabe":null,"status":"in_review","terms_of_service":null,"blacklist_validation_status":"succeeded","address":null,"govt_id":null,"proof_of_address":null,"proof_of_life":null,"beneficiaries":null,"names":"Miguel","first_surname":"Acosta","second_surname":"Ventura","curp":"AOVM910106HMCCNG07","rfc":"AOVM910106CH8"}' |
Contributor
There was a problem hiding this comment.
Sale un número de teléfono que existe. Quitarlo y quitar info personal si aparece
Contributor
There was a problem hiding this comment.
No se si el CURP sea real, creo que si del Mike
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
phone_verification_idyemail_verification_id#282