Skip to content

Conversation

@alexviquez
Copy link
Contributor

@alexviquez alexviquez commented Jan 11, 2023

This resource allows to validate users on lists

@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #343 (dac198c) into main (11e2608) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #343   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           43        47    +4     
  Lines         1005      1079   +74     
=========================================
+ Hits          1005      1079   +74     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cuenca/__init__.py 100.00% <ø> (ø)
cuenca/resources/__init__.py 100.00% <100.00%> (ø)
cuenca/resources/user_lists_validation.py 100.00% <100.00%> (ø)
cuenca/version.py 100.00% <100.00%> (ø)
cuenca/http/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11e2608...dac198c. Read the comment docs.

@alexviquez alexviquez marked this pull request as ready for review January 26, 2023 22:39
@alexviquez alexviquez requested a review from andreshndz January 26, 2023 22:40
andreshndz
andreshndz previously approved these changes Jan 27, 2023
Copy link
Contributor

@andreshndz andreshndz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version de CV y un solo comment

requirements.txt Outdated
@@ -1,3 +1,3 @@
requests==2.27.1
cuenca-validations==0.11.15
cuenca-validations==0.11.18.dev3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version

Comment on lines +69 to +72
curp='LOHJ660606HDFPRS02',
names='Alejandro',
first_surname='Martinez',
second_surname='Viquez',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esta prueba está hecha con un curp que no existe, esto no afecta en nada?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No afecta, si no existe validamos con nombres

@alexviquez alexviquez self-assigned this Jan 27, 2023
@alexviquez alexviquez added the enhancement New feature or request label Jan 27, 2023
@alexviquez alexviquez merged commit 67cf94b into main Jan 27, 2023
@alexviquez alexviquez deleted the user-lists branch January 27, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants