Skip to content

don't filter out user_id on responses#47

Merged
matin merged 3 commits intomainfrom
user_id
Aug 25, 2020
Merged

don't filter out user_id on responses#47
matin merged 3 commits intomainfrom
user_id

Conversation

@matin
Copy link
Copy Markdown
Contributor

@matin matin commented Aug 25, 2020

user_id is already being returned by the API, but it's currently being filtered out. All this does is ensure that it's not filtered out.

matin and others added 3 commits August 25, 2020 12:08
`user_id` is already being returned by the API, but it's currently being filtered out. All this does is ensure that it's not filtered out.
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 25, 2020

Codecov Report

Merging #47 into main will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #47   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          356       357    +1     
=========================================
+ Hits           356       357    +1     
Flag Coverage Δ
#unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cuenca/resources/base.py 100.00% <100.00%> (ø)
cuenca/version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a2c35d...dde917f. Read the comment docs.

@keryc
Copy link
Copy Markdown
Contributor

keryc commented Aug 25, 2020

@matin listo para revision, los cassettes no tenian el user_id pero oaxaca si lo tiene, hice pruebas de ello.

@matin matin merged commit f590470 into main Aug 25, 2020
@matin matin deleted the user_id branch August 25, 2020 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants