Skip to content

Card Transactions#80

Merged
alexviquez merged 21 commits intomainfrom
card_transactions
Nov 6, 2020
Merged

Card Transactions#80
alexviquez merged 21 commits intomainfrom
card_transactions

Conversation

@keryc
Copy link
Copy Markdown
Contributor

@keryc keryc commented Oct 21, 2020

Integration of CardTransaction

@keryc keryc self-assigned this Oct 21, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 21, 2020

Codecov Report

Merging #80 (d461449) into main (4293abc) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #80   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        16    +1     
  Lines          402       427   +25     
=========================================
+ Hits           402       427   +25     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cuenca/resources/card_transactions.py 100.00% <100.00%> (ø)
cuenca/resources/resources.py 100.00% <100.00%> (ø)
cuenca/version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4293abc...d461449. Read the comment docs.

@keryc keryc requested review from alexviquez and matin October 29, 2020 19:53
Copy link
Copy Markdown
Contributor

@alexviquez alexviquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renombrar variable error_type, quitar algunos tipados que ya son explicitos y quitar asserts que no son necesarios

@keryc keryc force-pushed the card_transactions branch from 65a1bf1 to fcfcb33 Compare October 29, 2020 22:21
@keryc keryc force-pushed the card_transactions branch from 726da4a to ae02f29 Compare November 3, 2020 23:48
@keryc keryc force-pushed the card_transactions branch from 8887e4d to 795e06d Compare November 4, 2020 00:15
@keryc keryc marked this pull request as ready for review November 4, 2020 00:15
@alexviquez alexviquez merged commit dbd1eb3 into main Nov 6, 2020
@alexviquez alexviquez deleted the card_transactions branch November 6, 2020 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants