Skip to content

Conversation

@alexviquez
Copy link

@alexviquez alexviquez commented Sep 12, 2022

BREAKING CHANGE

Se cambia la forma en la que se crean las verificaciones, en el api vieja se creaba primero un identity y después una verificación, esto ya no es necesario ya que MetaMap permite crear una verificación directo sin necesidad de tener que crear una identity, incluso al crearla retorna la identidad, más información en el siguiente enlace:
https://docs.metamap.com/reference/create-verification

@alexviquez alexviquez self-assigned this Sep 12, 2022
@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #98 (3245583) into master (fa0c450) will decrease coverage by 0.62%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##            master      #98      +/-   ##
===========================================
- Coverage   100.00%   99.37%   -0.63%     
===========================================
  Files           12       10       -2     
  Lines          356      318      -38     
===========================================
- Hits           356      316      -40     
- Misses           0        2       +2     
Flag Coverage Δ
unittests 99.37% <100.00%> (-0.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mati/resources/__init__.py 100.00% <ø> (ø)
mati/client.py 100.00% <100.00%> (ø)
mati/resources/verifications.py 100.00% <100.00%> (ø)
mati/types/enums.py 100.00% <100.00%> (ø)
mati/resources/base.py 95.45% <0.00%> (-4.55%) ⬇️
mati/resources/user_verification_data.py 96.55% <0.00%> (-3.45%) ⬇️
mati/__init__.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa0c450...3245583. Read the comment docs.

@alexviquez alexviquez changed the title Verifications create Verifications instaed of Identities (old) Sep 26, 2022
@alexviquez alexviquez changed the title Verifications instaed of Identities (old) Verifications instead of Identities (old) Sep 26, 2022
@alexviquez alexviquez merged commit d5c6df3 into master Sep 26, 2022
@alexviquez alexviquez deleted the verifications branch September 26, 2022 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants