chore: configure dependency propagation#178
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary of ChangesHello @cuioss-oliver, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces configuration for automated dependency propagation within the project's CI/CD pipeline. By defining consumers and propagation rules in Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds configuration for dependency propagation in .github/project.yml. The configuration for consumers appears correct. However, I've identified a potential issue in the dependency-propagation section regarding the scope value, which is not a standard Maven scope. I've left a specific comment with a suggestion to address this potential issue.
| dependency-propagation: | ||
| group-id: de.cuioss | ||
| artifact-id: cui-java-tools | ||
| scope: dependency |
There was a problem hiding this comment.
The value dependency for scope is not a standard Maven dependency scope. Valid scopes are compile, provided, runtime, test, system, and import. Using a non-standard scope might cause issues with the dependency propagation tooling if it expects a valid Maven scope. If the intention is for this to be a compile-time dependency for consumers, compile would be the correct value.
scope: compileThere was a problem hiding this comment.
The scope: dependency field here is not a Maven dependency scope. It's a custom configuration value for the cuioss dependency-propagation automation (see cuioss-organization v0.4.0). It distinguishes between scope: parent (update parent version in consumer POM) and scope: dependency (update a version property in consumer POM). Working as intended.
Summary
consumersanddependency-propagationconfig toproject.ymlcuioss-parent-pom(propertyversion.cui.java.tools) andnifi-extensionsTest plan
🤖 Generated with Claude Code