enhance: update pm-dev-frontend-cui skills and fix detect-change-type agent#52
Conversation
… agent - Fix ESLint v9 → v10 reference in dependency-management.md - Document ESLint v10 breaking changes (eslintrc removed) - Add Vitest recommendation for new standalone projects - Add TypeScript v7.0 ecosystem awareness note - Document Vite v8 Rolldown bundler in project-structure.md - Fix detect-change-type-agent: simplify decision tree, add post-check override in phase-3-outline for compound intent patterns Co-Authored-By: Claude <noreply@anthropic.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refines the automated classification of change types within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces valuable enhancements by updating the frontend development skills documentation and significantly improving the detect-change-type agent's logic for better clarity and robustness. The changes are well-structured and represent a positive step forward. I have identified a couple of minor opportunities for improvement to enhance consistency and classification accuracy, which are detailed in the review comments.
marketplace/bundles/plan-marshall/agents/detect-change-type-agent.md
Outdated
Show resolved
Hide resolved
marketplace/bundles/plan-marshall/skills/phase-3-outline/SKILL.md
Outdated
Show resolved
Hide resolved
- Reorder change_type enum to match decision tree priority - Add 'remove' to tech_debt action words in post-check override Co-Authored-By: Claude <noreply@anthropic.com>
Summary
Analysis Summary
All pm-dev-frontend-cui skills were analyzed for completeness, consistency, duplication, focus, and currency. The bundle is well-maintained with current version numbers (Node.js v24.14.0, ESLint v10, Jest v30, Vite v8, Prettier v3.8.1). Issues found were minor version references and missing documentation for recent ecosystem shifts.
Test plan
./pw verify pm-dev-frontend-cui— 54 tests pass, mypy clean, ruff clean