Skip to content

[DLST-463] fix dry-run and .temp directory bugs#3

Merged
goldsmithb merged 3 commits into
deploymentfrom
DLST-463
Aug 22, 2025
Merged

[DLST-463] fix dry-run and .temp directory bugs#3
goldsmithb merged 3 commits into
deploymentfrom
DLST-463

Conversation

@goldsmithb
Copy link
Copy Markdown
Contributor

@goldsmithb goldsmithb commented Aug 14, 2025

Jira Ticket Link

  1. Fixes a bug where .temp directories were not being deleted in dry-run mode (the call to the rm_temp_dirs method wasn't early enough in #email_and_exit)
  2. Fixes a bug where a .temp directory version of the uploaded dissertation directory already exists in the preservation location (this shouldn't happen due to the bugfix for point 1, but now we check for and handle this possibility)

Other changes:

  • (In SftpClient class) the method dissertations_dir_already_exists? has been replaced with the method check_dissertations_dir_already_exists - instead of returning a boolean value and having the caller raise an error if the result is true, now the function raises an error if the directory has already been downloaded, and returns an array with the string names of each directory to be downloaded (this value is immediately discarded for now, but could be used for logging/debugging purposes)

Comment thread lib/sftp_client.rb Outdated
Copy link
Copy Markdown
Member

@elohanlon elohanlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just left one minor suggestion about a method name.

goldsmithb and others added 2 commits August 22, 2025 16:36
Co-authored-by: Eric O <elohanlon@users.noreply.github.com>
@goldsmithb goldsmithb merged commit 34d4813 into deployment Aug 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants