[DLST-463] fix dry-run and .temp directory bugs#3
Merged
Conversation
elohanlon
reviewed
Aug 22, 2025
elohanlon
approved these changes
Aug 22, 2025
Member
elohanlon
left a comment
There was a problem hiding this comment.
Looks good! Just left one minor suggestion about a method name.
Co-authored-by: Eric O <elohanlon@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Ticket Link
rm_temp_dirsmethod wasn't early enough in#email_and_exit)Other changes:
dissertations_dir_already_exists?has been replaced with the methodcheck_dissertations_dir_already_exists- instead of returning a boolean value and having the caller raise an error if the result is true, now the function raises an error if the directory has already been downloaded, and returns an array with the string names of each directory to be downloaded (this value is immediately discarded for now, but could be used for logging/debugging purposes)