Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to remove JSONP-based endpoint checking so the feature table only uses CORS-based reachability/version checks, simplifying the UI and state handling around endpoint validation.
Changes:
- Removed the JSONP column and JSONP-related UI/actions from the feature table.
- Removed JSONP reachability state and JSONP manifest fetching logic from
FeatureRow. - Simplified
FeatureCellrendering by removing the JSONP “maybe / click to check” state and button.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/FeatureTable.jsx | Removes JSONP column/props and related explanatory UI; simplifies row keys. |
| src/FeatureRow.jsx | Deletes JSONP fetch/check path and JSONP reachability state; CORS-only reachability. |
| src/FeatureCell.jsx | Removes JSONP-specific “maybe” rendering and the “Check with JSONP” button. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| let span = <span className={glyph} sr-only={text} style={{color: color}}></span>; | ||
| let link = span; | ||
| if (this.props.onClick && this.props.value === 'maybe') { | ||
| link = <Button onClick={this.props.onClick} bsStyle="warning" bsSize="xsmall" title="Check with JSONP">{span}</Button> | ||
| } | ||
| return ( | ||
| <td className={'featureCell '+cellClass}> | ||
| {link} | ||
| {span} | ||
| </td> |
There was a problem hiding this comment.
sr-only is not a valid HTML/React attribute on a <span>, so this likely doesn't provide any screen-reader text. Consider using aria-label/title, or include a visually-hidden element with className="sr-only" containing the text, to make these status icons accessible.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This pull request removes all support for JSONP-based endpoint checking from the codebase, simplifying the logic to only support CORS-based checks. The changes affect the UI, internal state management, and related documentation.
Removal of JSONP support:
FeatureRow,FeatureCell, andFeatureTablecomponents, including thejsonpprop, JSONP-specific columns, and the "Check with JSONP" button. [1] [2] [3] [4] [5] [6] [7] [8]UI and documentation updates: