Refactor getGlobal to not cause CSP warnings#250
Merged
Conversation
|
Thanks for the nearly immediate response. You are amazingly fast. Maybe just don't see it. But did you actually include and use |
Contributor
Author
|
No, we can't use
The "real" change is https://github.com/cure53/DOMPurify/pull/250/files#diff-39d3e4cf739c51697e855107d73a23f5R5. However, I am not 100% sure if that covers all semantics/needs towards a |
806fb0c to
452a530
Compare
Contributor
Author
|
A now I see your point. Sorry |
Owner
|
Aaaand merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background & Context
This relates to #249.
Please critically reflect the old UMD interaction with the
factoryas inDOMPurify/src/purify.js
Lines 1 to 16 in a992d3a
Locally JSDOM and Karma against Chrome works fine.