IS-9422: updates templates to support same-device and cross-device flows#136
Conversation
| launch.view.qr.screen-reader.step4.2.2=Mac: Ctrl+Cmd+F | ||
| launch.view.qr.screen-reader.outro=Hålla telefonen i stående läge på ett 40cm avstånd från skärmen när du skannar QR-koden. | ||
| launch.view.button.show-qr-code=Visa QR-kod | ||
| launch.view.button.open-on-this-device=Öppna BankID på den här enheten |
There was a problem hiding this comment.
I don't get why we also need messages without the "button" qualifier in the path:
launch.view.show-qr-code launch.view.open-on-this-device does not look to be used.
There was a problem hiding this comment.
They were being used by HAAPI, however I removed them and changed the HAAPI representation so that it uses the exact same messages as the VM templates.
| #message("${_templatePrefix}.view.button.show-qr-code")</a> | ||
| </form> | ||
| <form name="cancel" action="cancel" class="manuallink display-none" method="get"> | ||
| #end |
There was a problem hiding this comment.
Previously, with the auto-start mode, the cancel button was hidden and then displayed after 5 seconds. Now it will be displayed from the beginning for both modes. Did you remove this behaviour voluntarily?
There was a problem hiding this comment.
Before my changes, my understanding is that the cancel button was always there when we have a QR code, which always happened for BankID v6.
| logger.debug("Not launching the app since the user previously cancelled in the app"); | ||
| #else | ||
| if (!browserStrategy.neverAutoLaunch) { | ||
| logger.debug("Launching the app"); |
pmhsfelix
merged commit 8633b10
into
feature/main/IS-9422-bankid-send-returnUrl-in-background
4 participants
Updates templates to support same-device and cross-device.
Needed by BE PR-9932.
See IS-9422.