Skip to content

IS-11474 Remove redundant curity-theme.css link from SSP loader template#243

Merged
urre merged 1 commit into
devfrom
fix/dev/IS-11474-remove-duplicate-curity-theme-css-link
Jun 23, 2026
Merged

IS-11474 Remove redundant curity-theme.css link from SSP loader template#243
urre merged 1 commit into
devfrom
fix/dev/IS-11474-remove-duplicate-curity-theme-css-link

Conversation

@urre

@urre urre commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

The theme_css_path variable (set in settings-defaults.vm, default /assets/css/curity-theme.css) already renders the curity-theme.css stylesheet link via the #if ($theme_css_path) block, so the hardcoded link produced a duplicate stylesheet on every SSP page. Removing it also makes the SSP respect $_staticResourceRootPath and a configured theme css path, consistent with core fragments/css.vm and the api-driven-ui template.

The theme_css_path variable (set in settings-defaults.vm, default
/assets/css/curity-theme.css) already renders the curity-theme.css
stylesheet link via the #if ($theme_css_path) block, so the hardcoded
link produced a duplicate stylesheet on every SSP page. Removing it also
makes the SSP respect $_staticResourceRootPath and a configured theme
css path, consistent with core fragments/css.vm and the api-driven-ui
template.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@urre urre requested a review from luisgoncalves June 23, 2026 09:04
@urre urre marked this pull request as ready for review June 23, 2026 09:04
Copilot AI review requested due to automatic review settings June 23, 2026 09:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes a duplicate curity-theme.css stylesheet reference from the Self Service Portal loader template so that theming is driven solely by theme_css_path (and therefore respects $_staticResourceRootPath and any configured theme CSS path), aligning SSP behavior with other UI templates/fragments.

Changes:

  • Removed the hardcoded /assets/css/curity-theme.css <link> from the SSP index.vm template to prevent duplicate theme stylesheet loading.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@urre urre merged commit 1ed66b2 into dev Jun 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants