Conversation
luisgoncalves
approved these changes
Mar 6, 2026
There was a problem hiding this comment.
Pull request overview
Updates shared button styles to better handle submit buttons that don’t have a complete “variant” class set, and to avoid forcing incorrect text color on outlined submit buttons.
Changes:
- Simplifies the submit-button selector using
:where()and a shorter exclusion list. - Adjusts text color behavior to avoid applying
color: whiteto outline variants. - Adds
width: 100%styling toa.button.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
markoweb
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the selector for buttons in templates that have non-complete button variant classes. It also fixes the label color on outlined buttons that are submit buttons.