replace unmaintained @reach/dialog with @radix-ui/react-dialog#82
Merged
vahag-curity merged 7 commits intodevfrom Mar 17, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates the shared Dialog component in the common component library from @reach/dialog to @radix-ui/react-dialog, updating styling and dependencies across the monorepo to support the new dialog implementation.
Changes:
- Replace
@reach/dialogusage with@radix-ui/react-dialogin the component-libraryDialogcomponent. - Update dialog overlay styling to align with Radix’s overlay/content structure.
- Update workspace dependencies and lockfile (including a
react-dompatch bump in the self-service-portal app).
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/self-service-portal/app/package.json | Removes @reach/dialog from the app deps and bumps react-dom patch version. |
| src/common/component-library/src/components/dialog/Dialog.tsx | Reimplements the dialog using Radix primitives and updates close callback typing/behavior. |
| src/common/component-library/src/components/dialog/Dialog.module.css | Updates overlay selector and adds explicit stacking order for overlay/content. |
| src/common/component-library/src/components/ConfirmButton.tsx | Aligns closeCallback typing with the dialog’s updated callback signature. |
| src/common/component-library/README.md | Updates internal dependency documentation to reference Radix dialog. |
| src/common/component-library/package.json | Swaps @reach/dialog for @radix-ui/react-dialog. |
| package-lock.json | Reflects dependency graph changes from the dialog library swap and version updates. |
Comments suppressed due to low confidence (1)
src/common/component-library/src/components/dialog/Dialog.tsx:23
closeDialogOnButtonClickis declared inCurityDialogPropsbut is not referenced anywhere in this component or elsewhere in the repo. Keeping unused props in a shared component API increases confusion for consumers—either remove it or implement the intended behavior (and add coverage) if it is still needed.
actionButtonText?: string;
isActionButtonDisabled?: boolean;
closeDialogOnButtonClick?: boolean;
actionButtonCallback?: (event: React.MouseEvent<HTMLButtonElement>) => void;
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…rid of all legacy-peer-deps=true in all the ui-kit projects
Wrap the title <p> with RadixDialog.Title and the subtitle <h2> with RadixDialog.Description using asChild, so screen readers properly announce the dialog content. Adds an empty RadixDialog.Description when no subtitle is provided to suppress Radix accessibility warnings. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove redundant nested .nvmrc files (22.12.0) from component-library and self-service-portal. All engine constraints use >=22.12.0 with no upper bounds, so 22.22.0 is compatible. This also aligns with the parent repo's Node version. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
urre
approved these changes
Mar 16, 2026
adnantariq-aurora
approved these changes
Mar 16, 2026
ambatimuralikrishna
approved these changes
Mar 16, 2026
aleixsuau
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@reach/dialogwith@radix-ui/react-dialog—@reach/dialogis unmaintained; Radix Dialog is actively maintained and supports React 16–19legacy-peer-deps=truefrom all.npmrcfilescomponent-librarydeclaredpeerDependencies: react ^18.0.0while actually using React 19^18.0.0 || ^19.0.0.npmrcfiles (root, component-library, self-service-portal, css/docs, css/lib)@types/reactand@types/react-domto^19incss/docsto match the actual React 19 runtime.npmrcto a single root file.npmrcfiles (22.12.0) fromcomponent-libraryandself-service-portal22.22.0to align with the parent repo