Skip to content

ngtcp2: use 0.15.0#11031

Closed
bagder wants to merge 2 commits into
masterfrom
bagder/bump-ngtcp2
Closed

ngtcp2: use 0.15.0#11031
bagder wants to merge 2 commits into
masterfrom
bagder/bump-ngtcp2

Conversation

@bagder
Copy link
Copy Markdown
Member

@bagder bagder commented Apr 26, 2023

Adapt to new API calls

@bagder bagder added the HTTP/3 h3 or quic related label Apr 26, 2023
@github-actions github-actions Bot added the CI Continuous Integration label Apr 26, 2023
@bagder bagder requested a review from tatsuhiro-t April 26, 2023 10:22
@bagder
Copy link
Copy Markdown
Member Author

bagder commented Apr 26, 2023

We can't upgrade yet, because we need nghttpx and it is a part of nghttp2 and it still uses the deprecated ngtcp2 APIs even in current git master so it fails to build.

@bagder
Copy link
Copy Markdown
Member Author

bagder commented Apr 26, 2023

nghttp2/nghttp2#1899

@tatsuhiro-t
Copy link
Copy Markdown
Contributor

nghttp2 v1.52 cannot be built with ngtcp2 v1.15. Please wait for nghttp2 v1.53 to upgrade.

@bagder bagder marked this pull request as draft April 26, 2023 10:58
@bagder
Copy link
Copy Markdown
Member Author

bagder commented May 8, 2023

@tatsuhiro-t any chance there is a nghttp2 release pending? We just ran into #11090 that seems to not happen on the latest ngtcp2 version, so we would like to take the jump...

@tatsuhiro-t
Copy link
Copy Markdown
Contributor

I will make new nghttp2 release tomorrow. I'm not sure the bug mentioned in #11090 has been fixed in the latest ngtcp2 release and main. Will check.

@pheiduck
Copy link
Copy Markdown
Contributor

Is there a rebase planned here?
nghttp2 v1.53 released today.

@bagder bagder force-pushed the bagder/bump-ngtcp2 branch from 20a1851 to b5873bc Compare May 12, 2023 10:54
@bagder bagder marked this pull request as ready for review May 12, 2023 10:54
@bagder bagder closed this in 10998e3 May 12, 2023
@bagder bagder deleted the bagder/bump-ngtcp2 branch May 12, 2023 15:26
@Izorkin Izorkin mentioned this pull request May 28, 2023
12 tasks
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
- nghttp3 0.11.0
- nghttp2 1.53.0

Adapt to new API calls

Closes curl#11031
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous Integration HTTP/3 h3 or quic related

Development

Successfully merging this pull request may close these issues.

3 participants