Skip to content

Comments

Fix HTTP/2 and H2-PROXY alive check and proxy drain#11368

Closed
icing wants to merge 2 commits intocurl:masterfrom
icing:h2-conn-alive-fix
Closed

Fix HTTP/2 and H2-PROXY alive check and proxy drain#11368
icing wants to merge 2 commits intocurl:masterfrom
icing:h2-conn-alive-fix

Conversation

@icing
Copy link
Contributor

@icing icing commented Jun 22, 2023

  • fix HTTP/2 check to not declare a connection dead when the read attempt results in EAGAIN
  • add H2-PROXY alive check as for HTTP/2 that was missing and is needed
  • add attach/detach around Curl_conn_is_alive() and remove these in filter methods
  • add checks for number of connections used in some test_10 proxy tunneling tests
  • fix stalling receives by setting drain when not all available tunnel data had been consumed. This fixes the gnutls pytest failures on my machine.

- fix HTTP/2 check to not declare a connection dead when
  the read attempt results in EAGAIN
- add H2-PROXY alive check as for HTTP/2 that was missing
  and is needed
- add attach/detach around Curl_conn_is_alive() and remove
  these in filter methods
- add checks for number of connections used in some test_10
  proxy tunneling tests
@icing icing changed the title Fix HTTP/2 and H2-PROXY connection alive check Fix HTTP/2 and H2-PROXY alive check and proxy drain Jun 22, 2023
@bagder bagder closed this in 873b958 Jun 22, 2023
@bagder
Copy link
Member

bagder commented Jun 22, 2023

Thanks!

bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
- fix HTTP/2 check to not declare a connection dead when
  the read attempt results in EAGAIN
- add H2-PROXY alive check as for HTTP/2 that was missing
  and is needed
- add attach/detach around Curl_conn_is_alive() and remove
  these in filter methods
- add checks for number of connections used in some test_10
  proxy tunneling tests

Closes curl#11368
ptitSeb pushed a commit to wasix-org/curl that referenced this pull request Sep 25, 2023
- fix HTTP/2 check to not declare a connection dead when
  the read attempt results in EAGAIN
- add H2-PROXY alive check as for HTTP/2 that was missing
  and is needed
- add attach/detach around Curl_conn_is_alive() and remove
  these in filter methods
- add checks for number of connections used in some test_10
  proxy tunneling tests

Closes curl#11368
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants