Pedantry/semantic-alignment between functions, docs, comments #11493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bch
commented
Jul 20, 2023
bch
commented
with respect to websocket protocol code; No functional change
intended.
* "totalsize", "framesize" becomes "fragsize" (we deal in frame fragments).
* "sendflags" becomes "flags"
* use canonical CURL *handle
bagder
approved these changes
Jul 21, 2023
Closed
Member
|
Thanks! |
ptitSeb
pushed a commit
to wasix-org/curl
that referenced
this pull request
Sep 25, 2023
Pedantry/semantic-alignment between functions, docs, comments with respect to websocket protocol code; No functional change intended. * "totalsize", "framesize" becomes "fragsize" (we deal in frame fragments). * "sendflags" becomes "flags" * use canonical CURL *handle Closes curl#11493
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.