Makefile.mk: always set CURL_STATICLIB for lib (Windows)#11924
Closed
vszakats wants to merge 2 commits into
Closed
Makefile.mk: always set CURL_STATICLIB for lib (Windows)#11924vszakats wants to merge 2 commits into
CURL_STATICLIB for lib (Windows)#11924vszakats wants to merge 2 commits into
Conversation
This fixes `-debug-dyn` builds with `-DCURL_STATICLIB` set.
This allows to drop `-DCURL_STATICLIB` from a custom `CPPFLAGS` (e.g. from curl-for-win). This in turn allows to enable `-dyn` builds, without exporting symbols from the static libcurl at the same time.
vszakats
changed the title
CURL_STATICLIB on WindowsCURL_STATICLIB for Windows
vszakats
changed the title
CURL_STATICLIB for WindowsCURL_STATICLIB (Windows)
vszakats
changed the title
CURL_STATICLIB (Windows)CURL_STATICLIB for lib (Windows)
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Sep 23, 2023
ptitSeb
pushed a commit
to wasix-org/curl
that referenced
this pull request
Sep 25, 2023
Also fix to export all symbols in Windows debug builds, making `-debug-dyn` builds work with `-DCURL_STATICLIB` set. Ref: curl#11914 (same for CMake) Closes curl#11924
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix to export all symbols in Windows debug builds, making
-debug-dynbuilds work with-DCURL_STATICLIBset.Ref: #11914 (same for CMake)
Closes #11924