Skip to content

x509asn1: add some common ECDSA OIDs#13857

Closed
Bo98 wants to merge 1 commit into
curl:masterfrom
Bo98:more-oids
Closed

x509asn1: add some common ECDSA OIDs#13857
Bo98 wants to merge 1 commit into
curl:masterfrom
Bo98:more-oids

Conversation

@Bo98
Copy link
Copy Markdown
Contributor

@Bo98 Bo98 commented Jun 2, 2024

ecdsa-with-SHA256 and ecdsa-with-SHA384 are used by GitHub.com's certificate chain

See #13845

@bagder
Copy link
Copy Markdown
Member

bagder commented Jun 2, 2024

Do we actually need this once we merge #13858?

@Bo98
Copy link
Copy Markdown
Contributor Author

Bo98 commented Jun 2, 2024

It's not necessary in order to fix #13845, but I think it still has some value in that it slightly improves the output of curl -w '%{certs}'.

Before (assuming #13858 already is applied):

Signature Algorithm:1.2.840.10045.4.3.2

After:

Signature Algorithm:ecdsa-with-SHA256

Which is consistent with what we already do for RSA certs:

Signature Algorithm:sha384WithRSAEncryption

and with how it is displayed for other SSL backends that do OID mapping themselves.

So I'd see #13858 as the real bugfix for #13845 and this PR as a cosmetic enhancement for ECDSA certs.

@bagder bagder closed this in eacec9a Jun 2, 2024
@bagder
Copy link
Copy Markdown
Member

bagder commented Jun 2, 2024

Lovely, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants