x509asn1: add some common ECDSA OIDs#13857
Closed
Bo98 wants to merge 1 commit into
Closed
Conversation
This was referenced Jun 2, 2024
Member
|
Do we actually need this once we merge #13858? |
Contributor
Author
|
It's not necessary in order to fix #13845, but I think it still has some value in that it slightly improves the output of Before (assuming #13858 already is applied): After: Which is consistent with what we already do for RSA certs: and with how it is displayed for other SSL backends that do OID mapping themselves. So I'd see #13858 as the real bugfix for #13845 and this PR as a cosmetic enhancement for ECDSA certs. |
Member
|
Lovely, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ecdsa-with-SHA256andecdsa-with-SHA384are used by GitHub.com's certificate chainSee #13845