socketpair: omit the function definition on Windows for disable-socketpair#13888
Closed
panjf2000 wants to merge 1 commit into
Closed
socketpair: omit the function definition on Windows for disable-socketpair#13888panjf2000 wants to merge 1 commit into
panjf2000 wants to merge 1 commit into
Conversation
panjf2000
changed the title
Member
|
Thanks! I'm currently traveling and will review tomorrow. (This looks trivial, but I still have to look at the original PR.) |
MarcelRaad
reviewed
Jun 6, 2024
panjf2000
force-pushed
the
disable-socketpair
branch
from
f6c03f8 to
7d5a66e
Compare
panjf2000
force-pushed
the
disable-socketpair
branch
from
7d5a66e to
2443525
Compare
MarcelRaad
approved these changes
Jun 7, 2024
Member
MarcelRaad
left a comment
MarcelRaad
left a comment
There was a problem hiding this comment.
Looks good to me and works for me, thanks! 👍
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates #13874
Ref: https://curl.se/dev/log.cgi?id=20240605035856-3529577