windows: drop dupe macros, detect CURL_OS for WinCE ARM, indentation#16029
Closed
vszakats wants to merge 6 commits into
Closed
windows: drop dupe macros, detect CURL_OS for WinCE ARM, indentation#16029vszakats wants to merge 6 commits into
CURL_OS for WinCE ARM, indentation#16029vszakats wants to merge 6 commits into
Conversation
vszakats
changed the title
curl_setup.h)Based on: https://cegcc.sourceforge.net/docs/details.html It shall also apply to MSVC.
vszakats
changed the title
CURL_OS for ARM, indentation
vszakats
changed the title
CURL_OS for ARM, indentationCURL_OS for ARM, indentation
vszakats
changed the title
CURL_OS for ARM, indentationCURL_OS for WinCE ARM, indentation
jay
reviewed
Jan 17, 2025
|
Analysis of PR #16029 at b34077f3: Test 780 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Generated by Testclutch |
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
- setup-win32: drop duplicate `WIN32_LEAN_AND_MEAN` and `NOGDI` macros (set earlier in `curl_setup.h`) - config-win32ce: detect ARM for `CURL_OS` macro. Based on: https://cegcc.sourceforge.net/docs/details.html It should also apply to MSVC. (untested) - indentation. Closes curl#16029
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup-win32: drop duplicate
WIN32_LEAN_AND_MEANandNOGDImacros(set earlier in
curl_setup.h)config-win32ce: detect ARM for
CURL_OSmacro.Based on: https://cegcc.sourceforge.net/docs/details.html
It should also apply to MSVC. (untested)
indentation.
w/o whitespace: https://github.com/curl/curl/pull/16029/files?w=1