h2, fix data_pending check#16098
Closed
icing wants to merge 1 commit into
Closed
Conversation
The h2 filter mistakenly also checked `sendbuf` when asked about pending data. The call is only meant to account for buffered data that still needs to be received. Also, remove obsolete recvbuf in stream as we write received headers and data directly. refs curl#16084
denizsokmen
reviewed
Jan 27, 2025
bagder
approved these changes
Jan 27, 2025
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
The h2 filter mistakenly also checked `sendbuf` when asked about pending data. The call is only meant to account for buffered data that still needs to be received. Also, remove obsolete recvbuf in stream as we write received headers and data directly. Fixes curl#16084 Closes curl#16098 Reported-by: Deniz Sökmen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The h2 filter mistakenly also checked
sendbufwhen asked about pending data. The call is only meant to account for buffered data that still needs to be received.Also, remove obsolete recvbuf in stream as we write received headers and data directly.
refs #16084