cmake: CURL_LIBDIRS improvements (upstreamed from vcpkg)#16610
Closed
vszakats wants to merge 2 commits into
Closed
cmake: CURL_LIBDIRS improvements (upstreamed from vcpkg)#16610vszakats wants to merge 2 commits into
CURL_LIBDIRS improvements (upstreamed from vcpkg)#16610vszakats wants to merge 2 commits into
Conversation
…DIRS Requires CMake 3.13, meaning it should be effective there or above but not supposed to break earlier versions just by adding this property.
vszakats
changed the title
CURL_LIBDIRS improvements (upstreamed from the vcpkg project)CURL_LIBDIRS improvements (upstreamed from vcpkg)
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Apply downstream patches from the vcpkg project:
- cmake: remove duplicates from `CURL_LIBDIRS`.
- cmake: set `CURL_LIBDIRS` as `INTERFACE_LINK_DIRECTORIES` for static
libcurl.
To support CMake <3.13, change downstream patch from:
```cmake
target_link_directories(${LIB_STATIC} INTERFACE ${CURL_LIBDIRS})
```
to:
```cmake
set_target_properties(${LIB_STATIC} PROPERTIES [...] INTERFACE_LINK_DIRECTORIES "${CURL_LIBDIRS}")
```
Co-authored-by: Kai Pastor
Ref: microsoft/vcpkg#43819
Closes curl#16610
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply downstream patches from the vcpkg project:
cmake: remove duplicates from
CURL_LIBDIRS.cmake: set
CURL_LIBDIRSasINTERFACE_LINK_DIRECTORIESfor staticlibcurl.
To support CMake <3.13, change downstream patch from:
to:
Co-authored-by: Kai Pastor
Ref: microsoft/vcpkg#43819