cmake: extend integration tests#17203
Closed
vszakats wants to merge 44 commits into
Closed
Conversation
This reverts commit d473ff0.
To avoid weird error affected new cmake, --verbose seems to accept an option?
This reverts commit de2be21.
Broken (both with old and new cmake):
```
-- TEST_INTEGRATION_MODE: ExternalProject
CMake Error at CMakeLists.txt:49 (find_package):
Could not find a package configuration file provided by "CURL" with any of
the following names:
CURLConfig.cmake
curl-config.cmake
Add the installation prefix of "CURL" to CMAKE_PREFIX_PATH or set
"CURL_DIR" to a directory containing one of the above files. If "CURL"
provides a separate development package or SDK, be sure it has been
installed.
```
modern is 3.15, unity needs 3.16, but will do.
vszakats
changed the title
Member
Author
|
Curious surprise this works out of the box. It either means these tests still |
vszakats
added a commit
that referenced
this pull request
Aug 7, 2025
By micromanaging the project dependency and its inclusion into the test project. It feels like an awkward construct, but perhaps better than nothing. It's also fragile because it's a static build with no assistance from the external project (curl in this case). Mitigated in test by disabling all dependencies and some features. Since there is no special core cmake logic to be tested here, in CI the test is tested really. To keep CI jobs at minimum, only add 3 of them, taking 42s in total. (All 6 would take 270s.) Follow-up to e2a23d5 #17203 Closes #18208
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExternalProjectcmake consumer test. It's broken.Cherry-picked from #16973