Skip to content

cmake: extend integration tests #17203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 44 commits into from
Closed

cmake: extend integration tests #17203

wants to merge 44 commits into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Apr 27, 2025 •
edited
Loading

  • GHA: add cmake integration tests for Windows.
  • make them run faster with prefill, unity, Ninja, omitting curl tool.
  • also test static libcurl.
  • add old-cmake support with auto-detection.
  • auto-detect Ninja.
  • run consumer test apps to see if they work.
  • add support for Windows.
  • make it more verbose.
  • re-add ExternalProject cmake consumer test. It's broken.
  • tidy up terminology.

Cherry-picked from #16973

@vszakats vszakats marked this pull request as draft April 27, 2025 10:27
@github-actions github-actions bot added tests CI Continuous Integration labels Apr 27, 2025
vszakats added 26 commits April 27, 2025 12:59
@vszakats
Revert "[TEST] cmake: integration tests w/o imported targets"
79b0ea9 
This reverts commit d473ff0.
@vszakats
cm: test static and shared, sync with libssh2
3687751
@vszakats
test order
3a1171d
@vszakats
test.sh: make cmakes customizable
aa759e7
@vszakats
test.sh: switch to Ninja automatically
478a889
@vszakats
test.sh: allow passing custom cmake options
35c6e34
@vszakats
test.sh: variabilize
ca37360
@vszakats
test.sh: variabilize 2
41196c5
@vszakats
test.sh: cleanup
a17bc01
@vszakats
test.sh: always verbose
3879ecf
@vszakats
test.sh: detect cmake version
9df5299
@vszakats
test.sh: cleanups
e0ae6bf
@vszakats
test.sh: cleanup
9526438
@vszakats
test.sh: version
845a1ae
@vszakats
test.sh: add support for old cmake
43a1fff
@vszakats
test.sh: cleanup
ba50ff4
@vszakats
test.sh: backtrack with --verbose
6739c6d 
To avoid weird error affected new cmake, --verbose seems to
accept an option?
@vszakats
test.sh: add recommended options
96d780e
@vszakats
Revert "test order"
4e9694a 
This reverts commit de2be21.
@vszakats
sigh --verbose option placement behaves differently in old cmake
1486fb5
@vszakats
tests/cmake: re-add broken ExternalProject (w/o running)
2293b07 
Broken (both with old and new cmake):
```
-- TEST_INTEGRATION_MODE: ExternalProject
CMake Error at CMakeLists.txt:49 (find_package):
  Could not find a package configuration file provided by "CURL" with any of
  the following names:

    CURLConfig.cmake
    curl-config.cmake

  Add the installation prefix of "CURL" to CMAKE_PREFIX_PATH or set
  "CURL_DIR" to a directory containing one of the above files.  If "CURL"
  provides a separate development package or SDK, be sure it has been
  installed.
```
@vszakats
test.sh: option order cleanup
4d987ea
@vszakats
test.sh: fix ninja detection
ad663c9
@vszakats
test.sh: do not pass custom curl cmake option to find_package consume…
970c73a 
…r build
@vszakats
tests/cmake: dependent -> consumer
ebc6a0f
@vszakats
test.sh: run test binaries
f0e93f4
vszakats added 17 commits April 27, 2025 13:01
@vszakats vszakats changed the title [TEST] cmake: integration tests w/o imported targets cmake: extend integration tests Apr 27, 2025
@vszakats vszakats marked this pull request as ready for review April 27, 2025 11:05
@vszakats
Copy link
Member Author

Curious surprise this works out of the box. It either means these tests still
don't actually test stuff we'd like to test, or that the notion of IMPORTED
targets is unnecessary. It'd guess it's the former. Either way this PR is fine
to merge.

@vszakats vszakats closed this in e2a23d5 Apr 27, 2025
@vszakats vszakats deleted the cm-test-wo-iface-tgt branch April 27, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI Continuous Integration tests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vszakats