tool_cb_wrt: stop alloc/free for every chunk windows console output#18233
Closed
tool_cb_wrt: stop alloc/free for every chunk windows console output#18233
Conversation
Instead realloc to the largest buffer and keep that for reuse during the entire lifetime. Written blindly because I don't develop on Windows.
bagder
force-pushed
the
bagder/windows-console
branch
from
4e77051 to
92835eb
Compare
Member
Author
|
This needs to be verified to work for real by someone on Windows before I dare to merge... |
jay
requested changes
Aug 11, 2025
Member
|
other than that looks ok |
fix Co-authored-by: Jay Satiro <raysatiro@yahoo.com>
fix Co-authored-by: Jay Satiro <raysatiro@yahoo.com>
Member
Author
|
thanks @jay ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead realloc to the largest buffer and keep that for reuse during the entire lifetime. Written blindly because I don't develop on Windows.