openssl: fix peer certificate leak in channel binding#18917
Closed
bagder wants to merge 2 commits into
Closed
Conversation
Member
Author
|
So this new test case reveals a second, different, leak that also needs to be fixed... |
Member
Author
|
This appears to be a memory leak inside heimdal as it does not reproduce with MIT krb5. This might be a signal that we should discourage use of heimdal? |
bagder
added a commit
that referenced
this pull request
Oct 8, 2025
The kerberos5 library Heimdal is one of three GSS libraries curl support. It has a memory leak triggered by the new test in #18917 and the project seems mostly abandoned. Drop support and steer users to the MIT krb5 or GNU GSS libraries.
vszakats
pushed a commit
to vszakats/curl
that referenced
this pull request
Oct 8, 2025
The kerberos5 library Heimdal is one of three GSS libraries curl support. It has a memory leak triggered by the new test in curl#18917 and the project seems mostly abandoned. Drop support and steer users to the MIT krb5 or GNU GSS libraries.
vszakats
pushed a commit
to vszakats/curl
that referenced
this pull request
Oct 8, 2025
The kerberos5 library Heimdal is one of three GSS libraries curl support. It has a memory leak triggered by the new test in curl#18917 and the project seems mostly abandoned. Drop support and steer users to the MIT krb5 or GNU GSS libraries.
|
Analysis of PR #18917 at 17755da0: Test 1582 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 6 different CI jobs (the link just goes to one of them). Test ../../tests/http/test_08_caddy.py::TestCaddy::test_08_03_download_1mb_parallel[h3] failed, which has NOT been flaky recently, so there could be a real issue in this PR. Generated by Testclutch |
vszakats
pushed a commit
to vszakats/curl
that referenced
this pull request
Oct 8, 2025
The kerberos5 library Heimdal is one of three GSS libraries curl support. It has a memory leak triggered by the new test in curl#18917 and the project seems mostly abandoned. Drop support and steer users to the MIT krb5 or GNU GSS libraries.
vszakats
pushed a commit
to vszakats/curl
that referenced
this pull request
Oct 8, 2025
The kerberos5 library Heimdal is one of three GSS libraries curl support. It has a memory leak triggered by the new test in curl#18917 and the project seems mostly abandoned. Drop support and steer users to the MIT krb5 or GNU GSS libraries.
vszakats
pushed a commit
to vszakats/curl
that referenced
this pull request
Oct 8, 2025
The kerberos5 library Heimdal is one of three GSS libraries curl support. It has a memory leak triggered by the new test in curl#18917 and the project seems mostly abandoned. Drop support and steer users to the MIT krb5 or GNU GSS libraries.
2 tasks
vszakats
pushed a commit
to vszakats/curl
that referenced
this pull request
Oct 8, 2025
The kerberos5 library Heimdal is one of three GSS libraries curl support. It has a memory leak triggered by the new test in curl#18917 and the project seems mostly abandoned. Drop support and steer users to the MIT krb5 or GNU GSS libraries.
vszakats
pushed a commit
to vszakats/curl
that referenced
this pull request
Oct 9, 2025
The kerberos5 library Heimdal is one of three GSS libraries curl support. It has a memory leak triggered by the new test in curl#18917 and the project seems mostly abandoned. Drop support and steer users to the MIT krb5 or GNU GSS libraries.
vszakats
added a commit
that referenced
this pull request
Oct 9, 2025
…n CI The kerberos5 library Heimdal is one of three GSS libraries curl support. It has a memory leak triggered by the new test in #18917 and the project seems mostly abandoned. Drop support and steer users to the MIT krb5 or GNU GSS libraries. Co-authored-by: Daniel Stenberg Ref: #18928 Closes #18928 Closes #18932
bagder
force-pushed
the
bagder/ossl-channel-binding
branch
from
17755da to
f35ebee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: https://hackerone.com/reports/3373640