Skip to content

test568: fix codespell, catch it next time early in CI#19945

Closed
vszakats wants to merge 3 commits into
curl:masterfrom
vszakats:spell568
Closed

test568: fix codespell, catch it next time early in CI#19945
vszakats wants to merge 3 commits into
curl:masterfrom
vszakats:spell568

Conversation

@vszakats
Copy link
Copy Markdown
Member

@vszakats vszakats commented Dec 12, 2025

Also:

  • GHA/checksrc: do not exclude tests/data/* changes.

Follow-up to 407d2f3 #19944

@github-actions github-actions Bot added the tests label Dec 12, 2025
@github-actions github-actions Bot added the CI Continuous Integration label Dec 12, 2025
@bagder
Copy link
Copy Markdown
Member

bagder commented Dec 12, 2025

We really should stop spellchecking the tests. This is a silly change...

Comment thread tests/data/test568 Outdated
s=SDP Seminar
i=A Seminar on the session description protocol
u=something somewthing something something somethin
u=something somewthing something something anything
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

somewthing is also not an English word...

@vszakats
Copy link
Copy Markdown
Member Author

vszakats commented Dec 12, 2025

IMO this is fine. We have comments and other text in tests, which is
probably better if they have no typos. As for fixing this one, no biggy.
It's the first time it caused an issue and a similar one can happen
anywhere. I think the recurring issue is that the checker is skipped
in CI, so not catching it early. Also fixing this case here.

@vszakats vszakats changed the title test568: fix codespell test568: fix codespell, catch it next time early in CI Dec 12, 2025
@vszakats vszakats closed this in 77eb669 Dec 12, 2025
@vszakats vszakats deleted the spell568 branch December 12, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous Integration tests

Development

Successfully merging this pull request may close these issues.

2 participants