Conversation
vszakats
marked this pull request as draft
February 20, 2026 13:22
vszakats
changed the title
bugprone-suspicious-realloc-usage, fix falloutsbugprone-macro-parentheses, fix fallouts
vszakats
marked this pull request as ready for review
February 20, 2026 17:24
vszakats
marked this pull request as draft
February 20, 2026 23:03
vszakats
marked this pull request as draft
February 20, 2026 23:03
vszakats
marked this pull request as ready for review
February 20, 2026 23:43
Also: - parsedate: avoid relying on side-effect of missing parentheses. Ref: https://clang.llvm.org/extra/clang-tidy/checks/bugprone/suspicious-realloc-usage.html
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
Also: - lib/parsedate: avoid relying on side-effect of missing parentheses. - lib/http: drop redundant parentheses. - fix cases in headers missed by clang-tidy. Ref: https://clang.llvm.org/extra/clang-tidy/checks/bugprone/macro-parentheses.html Closes curl#20647
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
Follow-up to 1393078 curl#20647 Closes curl#20674
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also:
Ref: https://clang.llvm.org/extra/clang-tidy/checks/bugprone/macro-parentheses.html