Closed
Conversation
When calling nghttp2 to delete session, clear the pointer to avoid risk of UAF. Pointed out by Codex Security
There was a problem hiding this comment.
Pull request overview
This PR mitigates a potential use-after-free risk in the HTTP/2 (nghttp2) connection filter by clearing the session pointer immediately after destroying the nghttp2 session.
Changes:
- After calling
nghttp2_session_del(), explicitly setctx->h2 = NULLto prevent accidental reuse of a freed session pointer.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
icing
approved these changes
Mar 18, 2026
Contributor
|
There is no code path where this "risking" happens. The improvement is valid, protecting from future call paths that may trigger this. |
dkarpov1970
pushed a commit
to dkarpov1970/curl
that referenced
this pull request
Mar 25, 2026
When calling nghttp2 to delete session, clear the pointer to avoid risk of UAF. Pointed out by Codex Security Closes curl#20975
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling nghttp2 to delete session, clear the pointer to avoid risk of UAF.
Pointed out by Codex Security