Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR hardens the .netrc parser’s handling of macdef sections so malformed content inside a macro definition (e.g., broken quotes) is skipped without tokenization or parse failures, and adds a regression test to cover the scenario.
Changes:
- Update
netrc_get_token()to treatMACDEFstate as “skip the entire line” and never tokenize macro-body content. - Add new regression test
test1672exercising amacdefcontaining a broken quote followed by a validmachineentry. - Register the new test in
tests/data/Makefile.am.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/netrc.c | Ensures macdef lines are fully ignored during parsing to avoid failures on malformed tokens/quotes. |
| tests/data/test1672 | Adds a regression test netrc file with macdef content containing a broken quote. |
| tests/data/Makefile.am | Includes test1672 in the distributed/known test list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
When skipping macdef lines inside netrc files, ignore it completely and do not tokenize or bail out on bad quotes. Follow-up to 3b43a05 Spotted by Codex Security
bagder
force-pushed
the
bagder/netrc-macdef
branch
from
8261f86 to
7e04c67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When skipping macdef lines inside netrc files, ignore it completely and do not tokenize or bail out on bad quotes.
Follow-up to 3b43a05
Spotted by Codex Security