tool_operate: keep the filename for upload globbing#21401
Closed
tool_operate: keep the filename for upload globbing#21401
Conversation
And output to a file. Which is odd, but should work and used to work.
Member
Author
|
Note that these tests now include and verify the #21402 "side-effect" |
There was a problem hiding this comment.
Pull request overview
This PR fixes curl tool-side behavior so that an explicitly selected output filename is preserved across repeated transfers triggered by upload globbing, and adds regression tests plus test-suite support/documentation for asserting empty stdout.
Changes:
tool_operate: duplicate (strdup) the configured per-URL output filename into each transfer instead of transferring ownership (so it remains available for subsequent iterations).- Test harness: add
%EMPTYsupport in<verify><stdout>to assert “stdout must be empty”, and document it. - Add new tests 2012/2013 covering upload globbing scenarios, and register them in the test Makefile.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/tool_operate.c |
Keeps configured u->outfile intact across multiple transfers by copying it into per->outfile. |
tests/runtests.pl |
Adds %EMPTY marker handling for <verify><stdout>. |
docs/tests/FILEFORMAT.md |
Documents %EMPTY usage for verifying empty stdout. |
tests/data/test2012 |
New regression test: URLs loaded from file + upload globbing. |
tests/data/test2013 |
New regression test: multiple URLs on command line + upload globbing. |
tests/data/Makefile.am |
Adds test2012/test2013 to the distributed test list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test 2012 and 2013 to verify.