hostip: init the curl_jmpenv_lock appropriately#21432
Closed
bagder wants to merge 1 commit into
Closed
Conversation
A zero-initialized static value is not guaranteed to be a valid mutex on all POSIX implementations Spotted by Codex Security
There was a problem hiding this comment.
Pull request overview
This PR fixes a portability issue in libcurl’s resolver timeout path by ensuring a global curl_simple_lock is initialized using the platform-appropriate initializer instead of relying on zero-initialization.
Changes:
- Initialize
curl_jmpenv_lockwithCURL_SIMPLE_LOCK_INITunderUSE_ALARM_TIMEOUTto ensure valid mutex/lock initialization on all supported platforms.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A zero-initialized static value is not guaranteed to be a valid mutex on all POSIX implementations
Spotted by Codex Security