Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples/progressfunc: make it build on older libcurls #2584

Closed
wants to merge 1 commit into from

Conversation

@bagder
Copy link
Member

commented May 18, 2018

This example was changed in ce2140a to use the new microsecond based
getinfo option. This change makes it conditionally keep using the older
option so that the example still builds with older libcurl versions.

examples/progressfunc: make it build on older libcurls
This example was changed in ce2140a to use the new microsecond based
getinfo option. This change makes it conditionally keep using the older
option so that the example still builds with older libcurl versions.
@bagder

This comment has been minimized.

Copy link
Member Author

commented May 18, 2018

@sjvs we get a lot of "irrelevant" lgtm failures atm, are you on top of these?

@sj

This comment has been minimized.

Copy link
Contributor

commented May 18, 2018

Hi @bagder! It would appear that the tiny bit of JavaScript that was in your repository before has disappeared, so the analysis for that language is now failing. We've now disabled JavaScript analysis for Curl, so PR analysis should succeed again. Thanks for flagging this up!

@bagder bagder closed this in ccf85d4 May 18, 2018

@bagder bagder deleted the bagder/older-version-progressfunc branch May 18, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Aug 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.