examples/progressfunc: make it build on older libcurls#2584
Closed
examples/progressfunc: make it build on older libcurls#2584
Conversation
This example was changed in ce2140a to use the new microsecond based getinfo option. This change makes it conditionally keep using the older option so that the example still builds with older libcurl versions.
Member
Author
|
@sjvs we get a lot of "irrelevant" lgtm failures atm, are you on top of these? |
Contributor
|
Hi @bagder! It would appear that the tiny bit of JavaScript that was in your repository before has disappeared, so the analysis for that language is now failing. We've now disabled JavaScript analysis for Curl, so PR analysis should succeed again. Thanks for flagging this up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This example was changed in ce2140a to use the new microsecond based
getinfo option. This change makes it conditionally keep using the older
option so that the example still builds with older libcurl versions.