examples/progressfunc: make it build on older libcurls #2584

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@bagder
Member

bagder commented May 18, 2018

This example was changed in ce2140a to use the new microsecond based
getinfo option. This change makes it conditionally keep using the older
option so that the example still builds with older libcurl versions.

examples/progressfunc: make it build on older libcurls
This example was changed in ce2140a to use the new microsecond based
getinfo option. This change makes it conditionally keep using the older
option so that the example still builds with older libcurl versions.
@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder May 18, 2018

Member

@sjvs we get a lot of "irrelevant" lgtm failures atm, are you on top of these?

Member

bagder commented May 18, 2018

@sjvs we get a lot of "irrelevant" lgtm failures atm, are you on top of these?

@sjvs

This comment has been minimized.

Show comment
Hide comment
@sjvs

sjvs May 18, 2018

Contributor

Hi @bagder! It would appear that the tiny bit of JavaScript that was in your repository before has disappeared, so the analysis for that language is now failing. We've now disabled JavaScript analysis for Curl, so PR analysis should succeed again. Thanks for flagging this up!

Contributor

sjvs commented May 18, 2018

Hi @bagder! It would appear that the tiny bit of JavaScript that was in your repository before has disappeared, so the analysis for that language is now failing. We've now disabled JavaScript analysis for Curl, so PR analysis should succeed again. Thanks for flagging this up!

@bagder bagder closed this in ccf85d4 May 18, 2018

@bagder bagder deleted the bagder/older-version-progressfunc branch May 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment