Skip to content

http2: only do the *done() cleanups for HTTP#5650

Closed
bagder wants to merge 1 commit intomasterfrom
bagder/http2-done-only-http
Closed

http2: only do the *done() cleanups for HTTP#5650
bagder wants to merge 1 commit intomasterfrom
bagder/http2-done-only-http

Conversation

@bagder
Copy link
Copy Markdown
Member

@bagder bagder commented Jul 3, 2020

This might fix the fuzzer issue.

@bagder bagder added the HTTP/2 label Jul 3, 2020
@laramiel
Copy link
Copy Markdown
Contributor

laramiel commented Jul 3, 2020

Where is the other place the cleanups might happen? When the h2 is destroyed is it set to null?

@bagder
Copy link
Copy Markdown
Member Author

bagder commented Jul 3, 2020

Curl_http_done is also called from rtsp_done(), and Curl_http_done calls the http2_done.

@bagder
Copy link
Copy Markdown
Member Author

bagder commented Jul 3, 2020

I''l merge this for now at least to fix the fuzzer issue, we can then look closer at #5648.

@bagder bagder closed this in 69bfde4 Jul 3, 2020
@bagder bagder deleted the bagder/http2-done-only-http branch August 30, 2020 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants