Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Add checksrc exceptions for testcode #6176

Conversation

@danielgustafsson
Copy link
Member

@danielgustafsson danielgustafsson commented Nov 5, 2020

The autobuilds are reporting checksrc warnings in libtest testcode on struct typedefs and the use of localtime. These are all done intentional to add exceptions to avoid warnings.

The autobuilds are reporting checksrc warnings in libtest testcode
on struct typedefs and the use of localtime. These are all done
intentional to add exceptions to avoid warnings.
@bagder
bagder approved these changes Nov 5, 2020
@MarcelRaad
Copy link
Member

@MarcelRaad MarcelRaad commented Nov 5, 2020

These are actually suppressed in https://github.com/curl/curl/blob/master/tests/libtest/.checksrc, but if I see it correctly that only works for the autobuilds using git, not the ones using the nightly tarball. Does that file maybe have to be added somewhere to appear there? I mean tests/libtest/.checksrc is not contained in https://curl.haxx.se/snapshots/curl-7.74.0-20201105.zip.

@danielgustafsson
Copy link
Member Author

@danielgustafsson danielgustafsson commented Nov 5, 2020

Good point, if it's included in when running make dist from maketgz it should just work it seems.

bagder added a commit that referenced this pull request Dec 21, 2020
... so that (auto)builds from tarballs also get the correct instructions.

Fixes #6176
@bagder
Copy link
Member

@bagder bagder commented Dec 21, 2020

The .checksrc files are not included in the dist properly! I'm fixing that in #6353 and I believe that is the correct fix for this.

@bagder bagder closed this in a93c647 Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants