Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tool_writeout: use _T types instead of doubles #6248

Closed
wants to merge 1 commit into from

Conversation

@bagder
Copy link
Member

@bagder bagder commented Nov 25, 2020

Commit 3b80d3c (June 2017) introduced these getinfo
variables that use curl_off_t instead of doubles. Now switch the
--write-out function to use them.

@bagder bagder added the cmdline tool label Nov 25, 2020
@emilengler
Copy link
Contributor

@emilengler emilengler commented Nov 25, 2020

Looks good to me but the commit message is a bit misleading IMO. The "_T" gives me C++ template flashbacks to some degree. I think "tool_writeout: use custom types instead of standard types" is a better message.

@bagder
Copy link
Member Author

@bagder bagder commented Nov 25, 2020

it refers to the curl_easy_getinfo() identifiers. I don't like "custom" vs "standard" as that's not the point. The point is rather that it uses a (large enough) fixed-point type instead of a floating point type.

Commit 3b80d3c (June 2017) introduced getinfo replacement
variables that use curl_off_t instead of doubles. Switch the --write-out
function over to use them.
@bagder bagder force-pushed the bagder/curl-writeout-t branch from 83d7c1b to fcfaffe Nov 25, 2020
@bagder bagder closed this in fc813f8 Nov 26, 2020
@bagder bagder deleted the bagder/curl-writeout-t branch Nov 26, 2020
bagder added a commit that referenced this pull request Dec 14, 2020
Fix regression from commit fc813f8 (#6248) that changed the unit
to microseconds instead of seconds with fractions

Fixes #6321
bagder added a commit that referenced this pull request Dec 15, 2020
Fix regression from commit fc813f8 (#6248) that changed the unit
to microseconds instead of seconds with fractions

Reported-by: 不确定
Fixes #6321
Closes #6322
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.